Skip to content

Fix #95079 unhelpful error when missing move in nested closure #99612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2022
Merged

Fix #95079 unhelpful error when missing move in nested closure #99612

merged 1 commit into from
Aug 16, 2022

Conversation

yanchen4791
Copy link
Contributor

Fix #95079 by adding help for missing move in nested closure

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 22, 2022
@rust-highfive
Copy link
Contributor

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 22, 2022
compiler-errors
compiler-errors requested changes Jul 22, 2022
View reviewed changes
@yanchen4791
Copy link
Contributor Author

@compiler-errors Could you review my refined changes? Please see outputs in #95079, thanks!

@jackh726
Copy link
Member

jackh726 commented Aug 7, 2022

r? @compiler-errors

@compiler-errors
Copy link
Member

compiler-errors commented Aug 14, 2022 •
edited
Loading

This is fine to merge, and if it has lots of false positives then I guess we can adjust or remove it.

@yanchen4791 can you rebase this onto the latest master?

@yanchen4791
Copy link
Contributor Author

@compiler-errors Thanks! It has been rebased to latest master.

@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 16, 2022

📌 Commit 15713e1 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 16, 2022
@bors
Copy link
Collaborator

bors commented Aug 16, 2022

⌛ Testing commit 15713e1 with merge a39bdb1...

@bors
Copy link
Collaborator

bors commented Aug 16, 2022

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing a39bdb1 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 16, 2022
@bors bors merged commit a39bdb1 into rust-lang:master Aug 16, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 16, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a39bdb1): comparison url.

Instruction count

  • Primary benchmarks: ✅ relevant improvement found
  • Secondary benchmarks: no relevant changes found
( ) mean1 max count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.4% -0.4% 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.4% -0.4% 1

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: mixed results
( ) mean1 max count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.7% 3.7% 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.1% -1.1% 1
All ❌✅ (primary) - - 0

Cycles

Results
  • Primary benchmarks: ❌ relevant regression found
  • Secondary benchmarks: no relevant changes found
( ) mean1 max count2
Regressions ❌
(primary)		 3.5% 3.5% 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 3.5% 3.5% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors requested changes

Assignees

@compiler-errors compiler-errors

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.

unhelpful error when missing move in nested closure
7 participants
@yanchen4791 @rust-highfive @jackh726 @compiler-errors @bors @rust-timer @rustbot